Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mmap cache option to QEMU mount #21089

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Add mmap cache option to QEMU mount #21089

merged 1 commit into from
Jan 1, 2024

Conversation

bc-lee
Copy link
Contributor

@bc-lee bc-lee commented Dec 26, 2023

This is required for mmap'ing on mounted files on MacOS Host. Closes #19639, #20055.

Does this PR introduce a user-facing change?

podman-machine: MacOS: Mount volumes with mmap enabled

@bc-lee
Add mmap cache option to QEMU mount
f10a7bf 
This is required for mmap'ing on mounted files on MacOS Host.
Closes containers#19639, containers#20055.

Signed-off-by: Byoungchan Lee <[email protected]>
@bc-lee bc-lee force-pushed the feature/podman-machine-mount-mmap branch from ab07cb7 to f10a7bf Compare December 26, 2023 09:37
@rhatdan
Copy link
Member

rhatdan commented Dec 26, 2023

LGTM
@gbraad @baude @slp WDYT?

cgwalters
cgwalters approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit the problem described here when using devcontainers; at least cargo/rustc use mmap to access some bits in the build process.

I've verified this PR fixes the problem.

@cgwalters
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2023
@baude
Copy link
Member

baude commented Jan 1, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, bc-lee, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2024
@baude
Copy link
Member

baude commented Jan 1, 2024

are there implications for linux and qemu ? also, it should be noted that qemu will be deprecated on mac in podman 5 in favor of the apple hypervisor

@openshift-merge-bot openshift-merge-bot bot merged commit 8dcd3b2 into containers:main Jan 1, 2024
19 checks passed
@bc-lee bc-lee deleted the feature/podman-machine-mount-mmap branch January 2, 2024 00:43
@bc-lee
Copy link
Contributor Author

bc-lee commented Jan 2, 2024

are there implications for linux and qemu ?

If someone uses Podman on Linux with QEMU, then they are also affected by this PR, for the same reasons.

also, it should be noted that qemu will be deprecated on mac in podman 5 in favor of the apple hypervisor

I didn't know that. Thanks for the info. FYI, I have some machines/users that still use Podman with Amd64 macOS machines, so I hope that Podman will continue to support QEMU implementation for a while.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees

@cgwalters cgwalters

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mmap in podman container returns ENODEV on MacOS Host
4 participants
@bc-lee @rhatdan @cgwalters @baude